Skip to content

[FrameworkBundle] disable the Lock integration to not register the deduplicate middleware #60559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented May 27, 2025

Q A
Branch? 7.3
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

Before the creation of the 7.4 branch the tests did not fail because on our high deps job we checked out the 7.2 branch and ran that with locally patched components (i.e. components that were changed by the commit being tested). On all other jobs the lock integration is disabled implicitly.

@xabbuh
Copy link
Member Author

xabbuh commented May 27, 2025

@stof
Copy link
Member

stof commented May 27, 2025

shouldn't default_middleware => false disable the deduplicate middleware even when the lock component is enabled ?

I would say this caught an actual bug.

@xabbuh
Copy link
Member Author

xabbuh commented May 27, 2025

@stof Yes, and that part works as expected. But we have three buses here and for the messenger.bus.commands and messenger.bus.events buses default_middleware is not set to false.

@xabbuh xabbuh force-pushed the deduplicate-middleware branch from 55e8879 to 3cf847f Compare May 28, 2025 06:56
@xabbuh xabbuh requested a review from stof May 28, 2025 07:02
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 8943c41 into symfony:7.3 May 28, 2025
10 of 11 checks passed
@xabbuh xabbuh deleted the deduplicate-middleware branch May 28, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants