[FrameworkBundle] ensureKernelShutdown in tearDownAfterClass #60564
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
ea858f6 to
feeac45
Compare
|
This relies on the child class calling the parent class. |
|
@nicolas-grekas I've added it in a new public method annotated with |
There was a problem hiding this comment.
I think it'd make more sense to me to add the annotation on the existing method.
My concern is about increasing the public API. People will start using the new method instead of the existing one in their test cases / IDEs will propose both, and people will wonder about that.
Also: I'm fine merging this as a bugfix, so 6.4 works for me.
This PR performs the following change: In
KernelTestCase, the kernel is shut down after every test, as per thestatic::ensureKernelShutdown()call in thetearDownfunction. However, if one was to perform any extra code in theirtearDownAfterClassand callgetContainer, it would boot up a new kernel, which would then be left dangling. The main issue with that is that when the next Test class is executed, there would already be a booted kernel, so it could happen that it was pointing to dangling resources.By adding this call to
static::ensureKernelShutdownin thetearDownAfterClass, we can ensure that no dangling kernels are left even after the test class has finished.