Skip to content

[Security] CleanUp UserInterface PHPDoc #60575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AboulhajHakim
Copy link

@AboulhajHakim AboulhajHakim commented May 28, 2025

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues --
License MIT

This PR removes outdated or potentially misleading references to passwords from the PHPDoc comments in the UserInterface. Since the interface does not directly handle password logic, these mentions are unnecessary and could cause confusion for implementers.

Changes:

  • Removed password-related text from PHPDoc comments in UserInterface.

Reasoning:

  • Clarifies the responsibilities of UserInterface.
  • Ensures documentation is aligned with actual interface behavior.

No functional code changes have been made—this is purely a documentation cleanup.

@AboulhajHakim AboulhajHakim requested a review from chalasr as a code owner May 28, 2025 15:35
@carsonbot carsonbot added this to the 7.4 milestone May 28, 2025
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title doc: CleanUp UserInterface PHPDoc [Security] doc: CleanUp UserInterface PHPDoc May 28, 2025
@nicolas-grekas nicolas-grekas changed the title [Security] doc: CleanUp UserInterface PHPDoc [Security] CleanUp UserInterface PHPDoc May 28, 2025
@nicolas-grekas nicolas-grekas modified the milestones: 7.4, 7.3, 6.4 May 30, 2025
@nicolas-grekas nicolas-grekas changed the base branch from 7.4 to 6.4 May 30, 2025 08:33
@nicolas-grekas nicolas-grekas force-pushed the doc/update-userInterface-doc branch from f11ff34 to e51a81a Compare May 30, 2025 08:33
@nicolas-grekas
Copy link
Member

Thank you @AboulhajHakim.

@nicolas-grekas nicolas-grekas merged commit 383eede into symfony:6.4 May 30, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants