[JsonPath] Always use brackets notation with JsonPath::key()
#60668
+133
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in the issue, the dot notation can lead to invalid paths when used with some identifiers (for example, when it contains a
-
). The issue gives the following example:Let's always use the brackets notation in
JsonPath::key()
. Dot notation is only a shorthand to the verbose brackets version and this solves the problem without having to do further analysis on the key.Added a few tests to ensure the brackets notation works well too.