[VarDumper] Fix ResourceCaster deprecation messages #60810
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jun 18, 2025
| @@ -29,7 +29,7 @@ class ResourceCaster | |||
| */ | |||
| public static function castCurl(\CurlHandle $h, array $a, Stub $stub, bool $isNested): array | |||
| { | |||
| trigger_deprecation('symfony/var-dumper', '7.3', 'The "%s()" method is deprecated without replacement.', __METHOD__, CurlCaster::class); | |||
| trigger_deprecation('symfony/var-dumper', '7.3', 'The "%s()" method is deprecated without replacement.', __METHOD__); | |||
There was a problem hiding this comment.
I think we should not even use the extra arguments there but use an explicit \sprintf call instead, which can be optimized by OPCache at compile time on recent PHP versions as we only use %s placeholders (the optimization supports %s and %d).
There was a problem hiding this comment.
And as another benefit, static analysis tools are able to detect such issues about mismatch for the number of parameters.
There was a problem hiding this comment.
Let me ignore this concern and merge: the patch is using the API the expected way and the perf topic looks minor to me.
|
Thank you @derrabus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pass more arguments to
trigger_deprecation()than the deprecation message has placeholders.