Add Route::hasOption() and Route::hasRequirement() methods. #6098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -234,6 +234,18 @@ public function getOption($name) | |||
| } | |||
|
|
|||
| /** | |||
| * Checks if a an option has been set | |||
| * | |||
| * @param string $name A variable name | |||
There was a problem hiding this comment.
this is the option name, not the variable name
There was a problem hiding this comment.
Fixed, rebased, repushed.
fabpot
added a commit
that referenced
this pull request
Nov 24, 2012
This PR was merged into the master branch. Commits ------- b930066 Add Route::hasOption() and Route::hasRequirement() methods. Discussion ---------- Add Route::hasOption() and Route::hasRequirement() methods. It seems odd that there's a hasDefault() method but not for options and requirements. Drupal has logic that depends on the existence of a given requirement. So let's add that. I think I got the coding standards right the first time for once... :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems odd that there's a hasDefault() method but not for options and requirements. Drupal has logic that depends on the existence of a given requirement. So let's add that.
I think I got the coding standards right the first time for once... :-)