Skip to content

[Config] Fix support for attributes on class constants and enum cases #61079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
+48 −0
Merged

[Config] Fix support for attributes on class constants and enum cases #61079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Symfony/Component/Config/Resource/ReflectionClassResource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,14 @@ private function generateSignature(\ReflectionClass $class): iterable
yield print_r($class->getConstants(), true);
}

foreach ($class->getReflectionConstants() as $constant) {
foreach ($constant->getAttributes() as $a) {
$attributes[] = [$a->getName(), (string) $a];
}
yield $constant->name.print_r($attributes, true);
$attributes = [];
}

if (!$class->isInterface()) {
$defaults = $class->getDefaultProperties();

Expand Down
40 changes: 40 additions & 0 deletions src/Symfony/Component/Config/Tests/Resource/ReflectionClassResourceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,30 @@ public function testIgnoresObjectsInSignature()
TestServiceWithStaticProperty::$initializedObject = new TestServiceWithStaticProperty();
$this->assertTrue($res->isFresh(0));
}

public function testEnum()
{
$res = new ReflectionClassResource($enum = new \ReflectionClass(SomeEnum::class));
$r = new \ReflectionClass(ReflectionClassResource::class);
$generateSignature = $r->getMethod('generateSignature')->getClosure($res);
$actual = implode("\n", iterator_to_array($generateSignature($enum)));
$this->assertStringContainsString('UnitEnum', $actual);
$this->assertStringContainsString('TestAttribute', $actual);
$this->assertStringContainsString('Beta', $actual);
}

public function testBackedEnum()
{
$res = new ReflectionClassResource($enum = new \ReflectionClass(SomeBackedEnum::class));
$r = new \ReflectionClass(ReflectionClassResource::class);
$generateSignature = $r->getMethod('generateSignature')->getClosure($res);
$actual = implode("\n", iterator_to_array($generateSignature($enum)));
$this->assertStringContainsString('UnitEnum', $actual);
$this->assertStringContainsString('BackedEnum', $actual);
$this->assertStringContainsString('TestAttribute', $actual);
$this->assertStringContainsString('Beta', $actual);
$this->assertStringContainsString('beta', $actual);
}
}

interface DummyInterface
Expand Down Expand Up @@ -262,3 +286,19 @@ class TestServiceWithStaticProperty
{
public static object $initializedObject;
}

enum SomeEnum
{
case Alpha;

#[TestAttribute]
case Beta;
}

enum SomeBackedEnum: string
{
case Alpha = 'alpha';

#[TestAttribute]
case Beta = 'beta';
}