-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[ObjectMapper] read source metadata before transform #61310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
soyuka
commented
Aug 3, 2025
Q | A |
---|---|
Branch? | 7.3 |
Bug fix? | yes |
New feature? | no |
Deprecations? | no |
Issues | fixes #61027 |
License | MIT |
Needs to account for #61027 (comment)? /cc @rvanlaak |
Will verify this within the hour, and potentially provide a commit with a test case to cherry-pick. |
@soyuka @nicolas-grekas added PR soyuka#2 with a test case and fix for #61027 (comment) |
…operty when not on source (#2)
c118fd2
to
c1e4adf
Compare
Thank you @soyuka. |
And thank you @rvanlaak |
As can be read on soyuka#2 the 7.3.2 release actually introduced a regression for ObjectMapper, as our CI pipeline was failing on the Renovatebot update PR to that release. As patch releases usually appear once per month, could this edge case regression on the experimental component be considered to be severe enough for an extra patch release in the upcoming days? 🙌 |
Are there any other changes in 7.3.2 that make it impossible to downgrade to 7.3.1/7.3.0 for the time until 7.3.3 is fixed at the regular schedule? |
No. And the BC itself is on an edge case, so scope of the impact is limited. We solely can not update to 7.3.2 and will stay on 7.3.1 until this PR gets released and our CI will turn green. It's mostly my over-eagerness that's asking that wants to start dropping all the boilerplate code for ObjectMapper implementations. |
I guess that's not an important enough reason for an extra release. 😉 |