[Security] Add $methods support to #[IsGranted] to restrict access by HTTP method
#61359
+96
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santysisi
commented
Aug 7, 2025
Comment on lines
+30
to
+35
| * @param string|Expression|\Closure(IsGrantedContext, mixed $subject):bool $attribute The attribute that will be checked against a given authentication token and optional subject | ||
| * @param array|string|Expression|\Closure(array<string,mixed>, Request):mixed|null $subject An optional subject - e.g. the current object being voted on | ||
| * @param string|null $message A custom message when access is not granted | ||
| * @param int|null $statusCode If set, will throw HttpKernel's HttpException with the given $statusCode; if null, Security\Core's AccessDeniedException will be used | ||
| * @param int|null $exceptionCode If set, will add the exception code to thrown exception | ||
| * @param string[]|string $methods HTTP methods to apply validation to. Empty array means all methods are allowed |
There was a problem hiding this comment.
When I ran php-cs-fixer, it automatically updated the PHPDoc blocks.
If it's preferred to handle those changes in a separate PR, just let me know 🙏
|
This is not a bug fix. |
66c7bd5 to
4cc3417
Compare
…s by HTTP method
4cc3417 to
739e36e
Compare
Comment on lines
+50
to
+51
| $methods = array_map('strtoupper', $attribute->methods); | ||
| if ($methods && !\in_array($request->getMethod(), $methods, true)) { |
There was a problem hiding this comment.
Suggested change
| $methods = array_map('strtoupper', $attribute->methods); | |
| if ($methods && !\in_array($request->getMethod(), $methods, true)) { | |
| if ($attribute->methods && !\in_array($request->getMethod(), array_map('strtoupper', $attribute->methods), true)) { |
nicolas-grekas
approved these changes
Aug 19, 2025
stof
reviewed
Aug 19, 2025
| @@ -24,19 +24,24 @@ | |||
| #[\Attribute(\Attribute::IS_REPEATABLE | \Attribute::TARGET_CLASS | \Attribute::TARGET_METHOD | \Attribute::TARGET_FUNCTION)] | |||
| final class IsGranted | |||
| { | |||
| public readonly array $methods; | |||
There was a problem hiding this comment.
should have @var string[] to document the exact type (especially as this is a public API)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for restricting
#[IsGranted]validation to specific HTTP methods via a new$methodsargument.What's New
You can now define access control per HTTP method directly in the
#[IsGranted]attribute. This allows greater flexibility when securing controller actions that handle multiple HTTP verbs.This change aligns
#[IsGranted]more closely with other HTTP-aware attributes like:#[IsCsrfTokenValid]#[IsSignatureValid](currently under review)