Skip to content

Remove direct access to internal properties cross-components #61452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

Remove direct access to internal properties cross-components #61452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Bridge/Doctrine/Tests/Validator/DoctrineLoaderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ public function testClassNoAutoMapping()

/** @var PropertyMetadata[] $autoMappingExplicitlyEnabledMetadata */
$autoMappingExplicitlyEnabledMetadata = $classMetadata->getPropertyMetadata('autoMappingExplicitlyEnabled');
$this->assertCount(1, $autoMappingExplicitlyEnabledMetadata[0]->constraints);
$this->assertCount(1, $autoMappingExplicitlyEnabledMetadata[0]->getConstraints());
$this->assertSame(AutoMappingStrategy::ENABLED, $autoMappingExplicitlyEnabledMetadata[0]->getAutoMappingStrategy());
}
}
4 changes: 2 additions & 2 deletions src/Symfony/Component/Form/Tests/Extension/Validator/ValidatorExtensionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ public function test2Dot5ValidationApi()
$this->assertCount(1, $metadata->getConstraints());
$this->assertInstanceOf(FormConstraint::class, $metadata->getConstraints()[0]);

$this->assertSame(CascadingStrategy::NONE, $metadata->cascadingStrategy);
$this->assertSame(TraversalStrategy::NONE, $metadata->traversalStrategy);
$this->assertSame(CascadingStrategy::NONE, $metadata->getCascadingStrategy());
$this->assertSame(TraversalStrategy::NONE, $metadata->getTraversalStrategy());
$this->assertCount(0, $metadata->getPropertyMetadata('children'));
}
}
6 changes: 3 additions & 3 deletions src/Symfony/Component/Security/Core/Tests/Validator/Constraints/UserPasswordTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,20 +42,20 @@ public static function provideServiceValidatedConstraints(): iterable
$metadata = new ClassMetadata(UserPasswordDummy::class);
self::assertTrue((new AttributeLoader())->loadClassMetadata($metadata));

yield 'attribute' => [$metadata->properties['b']->constraints[0]];
yield 'attribute' => [$metadata->getPropertyMetadata('b')[0]->getConstraints()[0]];
}

public function testAttributes()
{
$metadata = new ClassMetadata(UserPasswordDummy::class);
self::assertTrue((new AttributeLoader())->loadClassMetadata($metadata));

[$bConstraint] = $metadata->properties['b']->getConstraints();
[$bConstraint] = $metadata->getPropertyMetadata('b')[0]->getConstraints();
self::assertSame('myMessage', $bConstraint->message);
self::assertSame(['Default', 'UserPasswordDummy'], $bConstraint->groups);
self::assertNull($bConstraint->payload);

[$cConstraint] = $metadata->properties['c']->getConstraints();
[$cConstraint] = $metadata->getPropertyMetadata('c')[0]->getConstraints();
self::assertSame(['my_group'], $cConstraint->groups);
self::assertSame('some attached data', $cConstraint->payload);
}
Expand Down
Loading