Skip to content

[Config] Reduce the size of serialized resource checkers #61454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025
Merged

[Config] Reduce the size of serialized resource checkers #61454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/Symfony/Component/Config/Resource/ClassExistenceResource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,6 @@ public function isFresh(int $timestamp): bool
return $this->exists[0] xor !$exists[0];
}

/**
* @internal
*/
public function __serialize(): array
{
if (null === $this->exists) {
Expand All @@ -116,9 +113,6 @@ public function __serialize(): array
];
}

/**
* @internal
*/
public function __unserialize(array $data): void
{
$this->resource = array_shift($data);
Expand Down
7 changes: 7 additions & 0 deletions src/Symfony/Component/Config/Resource/ComposerResource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,13 @@ public function isFresh(int $timestamp): bool
return array_values(self::$runtimeVendors) === array_values($this->vendors);
}

public function __serialize(): array
{
return [
'vendors' => $this->vendors,
];
}

private static function refresh(): void
{
self::$runtimeVendors = [];
Expand Down
8 changes: 8 additions & 0 deletions src/Symfony/Component/Config/Resource/DirectoryResource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,4 +93,12 @@ public function isFresh(int $timestamp): bool

return true;
}

public function __serialize(): array
{
return [
'resource' => $this->resource,
'pattern' => $this->pattern,
];
}
}
8 changes: 8 additions & 0 deletions src/Symfony/Component/Config/Resource/FileExistenceResource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,12 @@ public function isFresh(int $timestamp): bool
{
return file_exists($this->resource) === $this->exists;
}

public function __serialize(): array
{
return [
'resource' => $this->resource,
'exists' => $this->exists,
];
}
}
7 changes: 7 additions & 0 deletions src/Symfony/Component/Config/Resource/FileResource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,11 @@ public function isFresh(int $timestamp): bool
{
return false !== ($filemtime = @filemtime($this->resource)) && $filemtime <= $timestamp;
}

public function __serialize(): array
{
return [
'resource' => $this->resource,
];
}
}
6 changes: 0 additions & 6 deletions src/Symfony/Component/Config/Resource/GlobResource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,6 @@ public function isFresh(int $timestamp): bool
return $this->hash === $hash;
}

/**
* @internal
*/
public function __serialize(): array
{
$this->hash ??= $this->computeHash();
Expand All @@ -93,9 +90,6 @@ public function __serialize(): array
];
}

/**
* @internal
*/
public function __unserialize(array $data): void
{
$this->prefix = array_shift($data);
Expand Down
3 changes: 0 additions & 3 deletions src/Symfony/Component/Config/Resource/ReflectionClassResource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,6 @@ public function __toString(): string
return 'reflection.'.$this->className;
}

/**
* @internal
*/
public function __serialize(): array
{
if (!isset($this->hash)) {
Expand Down
7 changes: 7 additions & 0 deletions src/Symfony/Component/Config/Resource/SkippingResourceChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,11 @@ public function isFresh(ResourceInterface $resource, int $timestamp): bool
{
return true;
}

public function __serialize(): array
{
return [
'skippedResourceTypes' => $this->skippedResourceTypes,
];
}
}
Loading