Skip to content

Conversation

MacDada
Copy link
Contributor

@MacDada MacDada commented Aug 27, 2025

Q A
Branch? 7.4
Bug fix? no
New feature? no
Deprecations? no
Issues no
License MIT

If it is "public", then for sure it is not "private".

#61505 (comment)

@carsonbot carsonbot added this to the 7.3 milestone Aug 27, 2025
@carsonbot carsonbot changed the title [DI]: removed unnecessary checks on Definitions and Aliases [DependencyInjection] : removed unnecessary checks on Definitions and Aliases Aug 27, 2025
@MacDada
Copy link
Contributor Author

MacDada commented Aug 27, 2025

argh, it should be for 7.4, not 7.3, right?

@xabbuh xabbuh changed the base branch from 7.3 to 7.4 August 27, 2025 12:25
@xabbuh xabbuh requested a review from dunglas as a code owner August 27, 2025 12:25
@xabbuh xabbuh changed the base branch from 7.4 to 7.3 August 27, 2025 12:27
@xabbuh
Copy link
Member

xabbuh commented Aug 27, 2025

argh, it should be for 7.4, not 7.3, right?

Yes, can you please rebase and then change the target branch? :)

@MacDada MacDada changed the base branch from 7.3 to 7.4 August 27, 2025 13:06
If it is "public", then for sure it is not "private".

symfony#61505 (comment)
@nicolas-grekas nicolas-grekas modified the milestones: 7.3, 7.4 Aug 27, 2025
@nicolas-grekas nicolas-grekas changed the title [DependencyInjection] : removed unnecessary checks on Definitions and Aliases [DependencyInjection] Removed unnecessary checks on Definitions and Aliases Aug 27, 2025
@MacDada
Copy link
Contributor Author

MacDada commented Aug 27, 2025

Yes, can you please rebase and then change the target branch? :)

I've re-done it on 7.4 👍

@nicolas-grekas
Copy link
Member

Thank you @MacDada.

@nicolas-grekas nicolas-grekas merged commit f6e37ef into symfony:7.4 Aug 27, 2025
10 of 12 checks passed
@MacDada MacDada deleted the public_private branch August 27, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants