[Security] Fix attribute-based chained user providers #61548
Merged
+33
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a723df9 to
9171141
Compare
9171141 to
8169616
Compare
nicolas-grekas
approved these changes
Aug 29, 2025
fabpot
approved these changes
Aug 30, 2025
|
Thank you @valtzu. |
|
PR welcome on 8.0 |
This was referenced Sep 2, 2025
fabpot
added a commit
that referenced
this pull request
Sep 3, 2025
…(valtzu) This PR was merged into the 6.4 branch. Discussion ---------- [Security] Pass attributes to nested `ChainUserProvider`s | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT Fix a missed corner case of #61548 found by `@nicolas`-grekas in #61594 (comment) _(Not needed on 8.0)_ Commits ------- cb75dd2 [Security] Pass attributes to nested `ChainUserProviders`
nicolas-grekas
added a commit
that referenced
this pull request
Sep 3, 2025
…sBasedUserProvider` (valtzu) This PR was merged into the 8.0 branch. Discussion ---------- [Security] Make `UserChainProvider` implement `AttributesBasedUserProvider` | Q | A | ------------- | --- | Branch? | 8.0 | Bug fix? | no | New feature? | yes | Deprecations? | no | License | MIT Related to #61548 Commits ------- 7d9a6d1 [Security] Make `UserChainProvider` implement `AttributesBasedUserProviderInterface`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attributes were not passed to an attribute-based user provider (
AttributesBasedUserProviderInterface) in aUserProviderChain.On 7.4 we could make
ChainUserProviderimplementAttributesBasedUserProviderInterface.