[JsonStreamer] Fix decoding iterable lists #61561
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fd4737d to
4dc00f4
Compare
4dc00f4 to
2b9b801
Compare
|
Thank you @mtarld. |
fabpot
added a commit
that referenced
this pull request
Sep 3, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [JsonStreamer] Fix encoding iterable lists | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT Sibling of #61561. Handle any iterable with `int` as key as a list during encoding (which mean being encoded with brackets). Commits ------- 2057bc8 [JsonStreamer] Fix encoding iterable lists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because a
list<T>is a subtype ofarray<T>, aniterable<T>cannot be a list.This means that, as said here:
This imply that it is right now impossible to "yield" items from
[{"itemId": 1, "modificationDate": "2025-10-10"}]- it can only be yielded from{"0": {"itemId": 1, "modificationDate": "2025-10-10"}}.I think that in the real world, a lot of people want to be able to yield items from
[...], even though it does not stick with the JSON specification.This PR is doing the trade-off of considering
iterable<int, Anything>as an "iterable list" (likelist<Anything>but not cast to array).