[DoctrineBridge] Use a single table in isSameDatabaseChecker #61582
+81
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
requested changes
Sep 3, 2025
src/Symfony/Bridge/Doctrine/SchemaListener/AbstractSchemaListener.php
Outdated
Show resolved
Hide resolved
ec4ed73 to
579a34e
Compare
OskarStark
approved these changes
Sep 3, 2025
mtarld
approved these changes
Sep 3, 2025
|
(rebase needed) |
579a34e to
0c5b355
Compare
|
Rebased. I also added a functional test using 2 in-memory sqlite databases. Other tests use mocks. |
8a5d0d4 to
842f10e
Compare
842f10e to
e2cc570
Compare
|
Thank you @GromNaN. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isSameDatabaseCheckerfeature of the SchemaListener detect if 2 DBAL connections are connected to the same server and database by creating a temporary table with one connection and checking if the table exists using the other connection.Creating a temporary table with a random name cause an issue to configure permissions, as an exhaustive list of table names can be required.
I propose to modify the implementation to always use the same table name, but insert a row with a random key with one connection and try to delete it with the other connection.
The table is dropped only if it is empty, to prevent concurrence issues.