[HttpFoundation][SQLSRV] Change column type from TEXT to STRING
#61585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.4" but it seems your PR description refers to branch "7.3". Cheers! Carsonbot |
xabbuh
approved these changes
Sep 2, 2025
TEXT to STRING
OskarStark
approved these changes
Sep 2, 2025
fabpot
approved these changes
Sep 2, 2025
Using TEXT for the id column results in doctrine setting SQL column to VARCHAR(MAX) which results in an SQL error since the primary key cannot be VARCHAR(MAX). This change allows Doctrine to see the length setting, which is ignored for TEXT objects.
c4b0bc1 to
8dcddb0
Compare
|
Thank you @Matt-PMCT. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using TEXT for the id column results in Doctrine setting the SQL column to VARCHAR(MAX) for SQL Server, which results in an SQL error since the primary key cannot be VARCHAR(MAX). This change enables Doctrine to recognize the length setting, which would otherwise be ignored for TEXT objects. This was described by the Doctrine Team here (doctrine/dbal#7126)