-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[Validator] Unify & more humane translation message for zh_CN #61586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
</trans-unit> | ||
<trans-unit id="111"> | ||
<source>The detected character encoding is invalid ({{ detected }}). Allowed encodings are {{ encodings }}.</source> | ||
<target>检测到的字符编码无效 ({{ detected }})。允许的编码为 {{ encodings }}。</target> | ||
<target>检测到的字符编码无效 ({{ detected }})。允许的编码为 {{ encodings }} 。</target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you added a few spaces before the final dots, is this legit? If not can you remove them all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Chinese writing, spaces are often used to separate English characters or numbers from Chinese characters (for example, 我叫Lee我今年18岁
would be written as 我叫 Lee 我今年 18 岁
) for visual clarity, so I've adopted this style.
In versions 7.3 and earlier, the trailing spaces have always been there; I just made them consistent in style.
https://github.com/symfony/validator/blob/7.3/Resources/translations/validators.zh_CN.xlf#L111C38-L111C39
https://github.com/symfony/validator/blob/7.3/Resources/translations/validators.zh_CN.xlf#L67C90-L67C91
https://github.com/symfony/validator/blob/7.3/Resources/translations/validators.zh_CN.xlf#L71C67-L71C68
Thank you @siganushka. |
Unify the translation message style and make the translation message more humane (the current one is too rigid)