Skip to content

[Cache] Make TagAwareAdapter registrable as a service #61599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

[Cache] Make TagAwareAdapter registrable as a service #61599

merged 1 commit into from
Sep 3, 2025

Conversation

dmitryuk
Copy link
Contributor

@dmitryuk dmitryuk commented Sep 3, 2025 •
edited
Loading

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #59193 #61114
License MIT

Fixes error while registering TagAwareAdapter as a service:

services:
  cache.adapter.array:
    class:  Symfony\Component\Cache\Adapter\ArrayAdapter
  cache.adapter.tag_aware_array:
    class: Symfony\Component\Cache\Adapter\TagAwareAdapter
    arguments:
      - '@cache.adapter.array'

framework:
    cache:
        pools:
            persistent.cache_pool:
                adapter: cache.adapter.tag_aware_array

TypeError: Symfony\Component\Cache\Adapter\TagAwareAdapter::__construct(): Argument #1 ($itemsPool) must be of type Symfony\Component\Cache\Adapter\AdapterInterface, string given, called in /var/www/var/cache/test/Container7bUFOLq/getPersistent_CachePoolService.php on line 28

Psalm failed unrelated

@carsonbot carsonbot added this to the 7.4 milestone Sep 3, 2025
@dmitryuk dmitryuk mentioned this pull request Sep 3, 2025
Closed
@OskarStark OskarStark changed the title [Cache] Make TagAwareAdapter registrable as a service [Cache] Make TagAwareAdapter registrable as a service Sep 3, 2025
OskarStark
OskarStark reviewed Sep 3, 2025
View reviewed changes
@nicolas-grekas
Copy link
Member

Looks like a bugfix to me, should target 6.4 then (the changelog line should be remove while rebasing)

@dmitryuk dmitryuk force-pushed the tag-aware-cache-pool branch from a4ed1ee to 05f273a Compare September 3, 2025 07:43
@dmitryuk dmitryuk changed the base branch from 7.4 to 6.4 September 3, 2025 07:43
@dmitryuk
Copy link
Contributor Author

dmitryuk commented Sep 3, 2025

Looks like a bugfix to me, should target 6.4 then (the changelog line should be remove while rebasing)

Rebased 6.4, thanks

@nicolas-grekas nicolas-grekas modified the milestones: 7.4, 6.4 Sep 3, 2025
nicolas-grekas
nicolas-grekas reviewed Sep 3, 2025
View reviewed changes
@nicolas-grekas
Copy link
Member

Thank you @dmitryuk.

@nicolas-grekas nicolas-grekas merged commit 3cd859f into symfony:6.4 Sep 3, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@OskarStark OskarStark OskarStark left review comments

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

Assignees
No one assigned
Labels
Cache Feature Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

[Cache] Issue in tests while creating mock for taggable cache.pool
4 participants
@dmitryuk @nicolas-grekas @OskarStark @carsonbot