[Validator] review the French translations #61648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Sep 4, 2025
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix #61632 |
| License | MIT |
| </trans-unit> | ||
| <trans-unit id="128"> | ||
| <source>The video has too few pixels ({{ pixels }} pixels). Minimum amount expected is {{ min_pixels }} pixels.</source> | ||
| <target state="needs-review-translation">La vidéo a trop peu de pixels ({{ pixels }}). La quantité minimale attendue est {{ min_pixels }}.</target> | ||
| <target>La vidéo a trop peu de pixels ({{ pixels }}). La quantité minimale attendue est de {{ min_pixels }} pixels.</target> |
There was a problem hiding this comment.
FTR, I removed the word "pixels" from all translation in order to not have to deal with plurals: the original sentence has two plurals, and our simple plural system cannot handle this. I made the translated sentences contain none.
Of course, I'm fine re-adding the word. Here, we make the assumption that min_pixel will always be higher than 1. That might be fine.
There was a problem hiding this comment.
that might be fine in French. Some other locales where plural rules are more complex (locales where not all numbers > 1 use the same plural form) won't be able to make the same assumption.
|
Thank you @lyrixx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.