Skip to content

upgrade ICU_DATA_VERSION to 50 #6198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

upgrade ICU_DATA_VERSION to 50 #6198

wants to merge 2 commits into from

Conversation

toaotc
Copy link

@toaotc toaotc commented Dec 5, 2012

in ICU_DATA_VERSION 49

use Symfony\Component\Locale\Locale;

(count(Locale::getDisplayCountries('de')) != count(Locale::getDisplayCountries('en')))
/* 255 != 259 */

in ICU_DATA_VERSION 50

/* 258 == 258 */

changelog:

  • const ICU_DATA_VERSION = '50'; in Locale class
  • removed Resources/data/49
  • added 50 version reference in Resources/data/icu.ini
  • ran php Resources/data/build-data.php 50 (!?!got parse errors!?!)

@stof
Copy link
Member

stof commented Dec 5, 2012

which parse errors ?

@lutzportela
Copy link

this parse errors:

.../Resources/data/50/names/generated/he.txt:270: parse error. Stopped parsing resource with U_ILLEGAL_CHAR_FOUND
.../Resources/data/50/names/generated/he.txt:2: parse error. Stopped parsing resource with U_ILLEGAL_CHAR_FOUND
couldn't parse the file .../Resources/data/50/names/generated/he.txt. Error:U_ILLEGAL_CHAR_FOUND
.../Resources/data/50/names/generated/he_IL.txt:270: parse error. Stopped parsing resource with U_ILLEGAL_CHAR_FOUND
.../Resources/data/50/names/generated/he_IL.txt:2: parse error. Stopped parsing resource with U_ILLEGAL_CHAR_FOUND
couldn't parse the file .../Resources/data/50/names/generated/he_IL.txt. Error:U_ILLEGAL_CHAR_FOUND
.../Resources/data/50/names/generated/iw.txt:270: parse error. Stopped parsing resource with U_ILLEGAL_CHAR_FOUND
.../Resources/data/50/names/generated/iw.txt:2: parse error. Stopped parsing resource with U_ILLEGAL_CHAR_FOUND
couldn't parse the file .../Resources/data/50/names/generated/iw.txt. Error:U_ILLEGAL_CHAR_FOUND
.../Resources/data/50/names/generated/iw_IL.txt:270: parse error. Stopped parsing resource with U_ILLEGAL_CHAR_FOUND
.../Resources/data/50/names/generated/iw_IL.txt:2: parse error. Stopped parsing resource with U_ILLEGAL_CHAR_FOUND
couldn't parse the file .../Resources/data/50/names/generated/iw_IL.txt. Error:U_ILLEGAL_CHAR_FOUND

@fabpot
Copy link
Member

fabpot commented Dec 14, 2012

ping @eriksencosta

@fabpot
Copy link
Member

fabpot commented Dec 14, 2012

I've just added support for ICU data version 50 (c0507aa) so that when you have this version of ICU, you can still run the tests. And I can confirm that:

  • there are some parsing errors
  • some tests are broken (as things changed)

@ghost
Copy link

ghost commented Dec 16, 2012

Sorry guys. I am with a strong conjunctivitis and can't stand in front of a computer for too much time. @fabpot I will take a look of all the issues you referenced me when get better (I hope still in 2012).

@ghost
Copy link

ghost commented Jan 6, 2013

@fabpot I'm recovered from my illness, and will work on the Locale issues this month. I'll take a careful look on the issues.

The development phase for 2.2 ended, right? Can I upgrade the ICU data files to the version 50 for this release while on the stabilization phase?

@fabpot
Copy link
Member

fabpot commented Mar 6, 2013

Closing this issue as @bschussek is working on a better solution.

@fabpot fabpot closed this Mar 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@toaotc @stof @lutzportela @fabpot