[HttpFoundation] Default request _format should be aware of HTTP Accept header
#6276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been discussed a very long time ago and we decided to not support this out of the box as it has many drawbacks (mainly due to the fact that browsers return weird Accept header values -- has it changed now?). So, if we support this, it should be optional/asked explicitly. |
|
@fabpot as "optional/asked" you mean something like actual public function getRequestFormat($default = 'html', $useAcceptHeader = false) |
|
Closing as it does not play well with browsers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: no
Feature addition: yes
Backwards compatibility break: yes (?)
Symfony2 tests pass: yes
Fixes the following tickets: #4567
Possible BC break would be in really edge case that is user sets
$defaultformat and expects it will be returned but now ifAcceptheader is set, it has priority over default value.