[HttpKernel] fixed kernel re-init (when getting unserialized for eg.) #6326
Conversation
When a kernel object gets unserialized, it's being constructed, then initialized, there shouldn't be any need to call the init method twice in a process, it basically only contains static calls affecting some PHP ini settings or error handlers, actually it can lead to unexpected things if it's called more than once, for eg. having duplicate error messages or registering DebugClassLoaders for DebugClassLoaders. Imo this method shouldn't even be publicly accessible, but I didn't wanted to break things.
|
I'd rather fix the root cause because IIUC, in your case, you then have 2 kernels. |
|
Yes but I don't think this is specific to me, I can see the kernel has been designed to support serialization (it implements Serializable), so the same issue will likely occur anytime the kernel or a class depending on the kernel gets unserialized. It looks related to some Symfony internals, here is the class causing me this issue : https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/Config/FileLocator.php This class depends on the Kernel, and an instance of it is being serialized in If nobody can reproduce this I'll try to push something on github. |
|
I'm getting this error with a fresh standard edition (latest and deps updated to their latest too) if I only remove the semi-colon at the end of this line for eg : https://github.com/symfony/symfony-standard/blob/master/src/Acme/DemoBundle/Controller/DemoController.php#L30 and request the |
|
@mpdude : this "init()" method has been deprecated, so it's fixed now. |
fixes #6254
This was happening to me because in
app/cache/dev/appDevUrlMatcher.php.metaI have aSymfony\Component\HttpKernel\Config\FileLocatorserialized object, at some point a ConfigCache needs to unserialize this file, when it does, a Kernel gets unserialized too (because this FileLocator class depends on it), and it leads to re-initializing the kernel.