[Validator] CardScheme improvements #6450
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $schemes = array_flip($constraint->schemes); | ||
| } else { | ||
| $schemes = array($constraint->schemes => 0); | ||
| } |
There was a problem hiding this comment.
$schemes = array_flip((array) $constraint->schemes); would be shorter
|
True @stof! I changed this. |
| ->method('addViolation'); | ||
|
|
||
| $this->validator->validate($number, new CardScheme(array('schemes' => $schemes))); | ||
| } |
There was a problem hiding this comment.
The code of the test is exactly the same than the previous one. Simply merge both data providers together
|
@Sgoettschkes Could you please squash those commits and give "better" message? i.e. |
|
Done. |
|
Closing in favor of #6583 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
License of the code: MIT
Documentation PR: -