[Locale] Rolled back normalizeIcuVersion() method in unit tests. #6568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it consistent with 2.0 and 2.1. We just need to check if version is 4.4 or 4.8 and we do not need to know if it is 4.8.0 or 4.8.1.1 (at least for now there are no big differences between minor ICU versions).
fabpot
added a commit
that referenced
this pull request
Jan 5, 2013
This PR was merged into the master branch. Commits ------- 310f691 [Propel1] Fixed preferred choices in the ModelChoiceList. Discussion ---------- [Propel1] Fixed preferred choices in the ModelChoiceList Related change was made in #6454 but for some reason part of that change was not merged from 2.1 branch. Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: some Locale tests fail, fixed in #6568 Fixes the following tickets: Todo: - License of the code: MIT Documentation PR: -
fabpot
added a commit
that referenced
this pull request
Jan 5, 2013
This PR was merged into the master branch. Commits ------- 97bc257 [Locale] Rolled back normalizeIcuVersion() method in unit tests. Discussion ---------- [Locale] Rolled back normalizeIcuVersion() method in unit tests. We just need to check if version is 4.4 or 4.8 and we do not need to know if it is 4.8.0 or 4.8.1.1 (at least for now there are no big differences between minor ICU versions). This change basically rolls back modifications made in #6109 to fix #5288. Those modifications didn't really fix the issue since ICU>=4.9 wasn't handled properly. Part of the roll back was made in #6515 (2.1 branch). This change makes master branch consistent with what we have in 2.0 and 2.1 (bespoke tests are passing in those branches). Bug fix: no Feature addition: no Backwards compatibility break: no Symfony2 tests pass: one test fails in the Propel1 bridge Fixes the following tickets: #5517 Todo: - License of the code: MIT Documentation PR: -
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just need to check if version is 4.4 or 4.8 and we do not need to know if it is 4.8.0 or 4.8.1.1 (at least for now there are no big differences between minor ICU versions).
This change basically rolls back modifications made in #6109 to fix #5288. Those modifications didn't really fix the issue since ICU>=4.9 wasn't handled properly. Part of the roll back was made in #6515 (2.1 branch).
This change makes master branch consistent with what we have in 2.0 and 2.1 (bespoke tests are passing in those branches).
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: one test fails in the Propel1 bridge
Fixes the following tickets: #5517
Todo: -
License of the code: MIT
Documentation PR: -