[2.3] [FrameworkBundle] [Serializer] Loads the Serializer component as a service in the Framework Bundle #6815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -112,6 +112,10 @@ public function load(array $configs, ContainerBuilder $container) | |||
|
|
|||
| $this->registerAnnotationsConfiguration($config['annotations'], $container, $loader); | |||
|
|
|||
| if (isset($config['serializer'])) { | |||
| $this->registerSerializerConfiguration($config['serializer'], $loader); | |||
There was a problem hiding this comment.
There is no point for such method, that do nothing more than one if check...
|
Thanks loalf! Any news on if / when this will be merged in? |
|
Thanks @peterhone. You better ask @fabpot or someone in the core. |
| ->children() | ||
| ->arrayNode('serializer') | ||
| ->info('serializer configuration') | ||
| ->canBeDisabled() |
There was a problem hiding this comment.
I would make it disabled by default. So, it should be canbeenabled here.
|
@fabpot changed |
fabpot
added a commit
that referenced
this pull request
Mar 23, 2013
This PR was merged into the master branch. Discussion ---------- [2.3] [FrameworkBundle] [Serializer] Loads the Serializer component as a service in the Framework Bundle This PR is the same as #5347 but since I am struggling to squash all the commits I better create a new one. Sorry for the inconveniences, :) Commits ------- b4e4844 Add the serializer service
fabpot
added a commit
that referenced
this pull request
Dec 12, 2014
…e by default (dunglas) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #12295). Discussion ---------- [FrameworkBundle] make GetSetMethodNormalizer available by default | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | very limited | Deprecations? | no | Tests pass? | yes | License | MIT | Doc PR | not yet The `GetSetMethodNormalizer` has not been enabled by default in #6815 because it was broken by design. Since #12098 has been merged, circular references are handled and that normalizer cannot breaks applications. This PR makes that normalizer automatically available when the serializer is enabled. To keep BC, I've set a "high" priority for this service (higher than the default `0`). Commits ------- 4f0aa61 [FrameworkBundle] make GetSetMethodNormalizer available by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the same as
#5347
but since I am struggling to squash all the commits I better create a new one. Sorry for the inconveniences, :)