Skip to content

[2.2][SecurityBundle] Renamed pattern to path for firewalls, conform the routing changes #6894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[2.2][SecurityBundle] Renamed pattern to path for firewalls, conform the routing changes #6894

wants to merge 1 commit into from

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jan 27, 2013

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets -
License MIT
Doc PR not yet
Related PR #6738

@wouterj
Renamed pattern to path for firewalls, conform the routing changes
6016449 
| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | not yet
@stof
Copy link
Member

stof commented Jan 28, 2013

This is not a path at all. It is the regex pattern concerned by the firewall. It does not make any sense to rename it path.
And this has nothing to do with the name of the property in the route class, so it does not make sense to mark the other PR as related

@fabpot
Copy link
Member

fabpot commented Feb 4, 2013

I agree with @stof.

@fabpot fabpot closed this Feb 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wouterj @stof @fabpot