[Routing] remove route query param when it is the same as default #6905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's a bc break. And I think fixing this inconsistency would be better the other way round: see #5410 |
|
i agree with @Tobion as the approach in #5410 would prevent breaking bookmarks if the defaults change. at the same time this way urls might be needlessly long, which can cause confusions when users copy urls to each other. so ideally it would be up to the developer the decide what behavior they want. |
|
Exactly the developer should have to possibility to decide. Which is what #5410 makes possible. Currently the developer is forced in one way (which is even inconsistent between placeholders and query params). |
|
Closing in favor of the discussion in #5410 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think the original testcase for query params is broken see:
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Routing/Tests/Generator/UrlGeneratorTest.php#L294
the
generatemethod from theUrlGeneratorremoves parameter that has the same value as the default see:https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Routing/Tests/Generator/UrlGeneratorTest.php#L344
but this is not the case for query parameters