-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[2.3] [Form] New CollectionType prototype_data option #6910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.3] [Form] New CollectionType prototype_data option #6910
Conversation
you should provide a doc PR |
I've created a PR on the documentation for this feature. |
In case anyone can't wait for this feature to be merged (or is still using |
What about a more generic prototype-option ? |
@vicb there is already |
Are nesting or user defined options some uc ? (note to myself: merge) |
ping |
@gimler this is a new feature, and 2.2 is in its RC cycle. So it would have to wait for 2.3. The priority currently is to stabilize 2.2, not to merge PRs for 2.3 |
'type' => 'form', | ||
'allow_add' => true, | ||
'prototype' => true, | ||
'prototype_data' => $data = 'foobar', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imho, using a assignement here is confusing and not really needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @pborreli. Please change this to test directly against 'foobar' below.
Does any more work need doing to this other than updating the test that @pborreli mentioned? It would be great to get this in 2.1 as well as 2.2 if possible. |
ref #6350 |
ref #3825 |
@bschussek Will this addition get into 2.3? |
No. 2.3 is in feature freeze. |
This I know, I just wanted to ping again to get the state. Its pending now for some time, hope that it will quickly get in. |
also looking for this feature |
@Venzon As said above, it is easy to do it usign a type extension waiting for it to be merged. See the gist linked by @adrienbrault |
@stof thanks a lot, I did not notice this gist |
@adrienbrault @stof
Inside TagType class
|
Closed in favor of #9177 |
@bschussek I'm not sure the related issue would allow fixing it: it should overwrite the |
Hey