[2.3] [WebProfiler] Add PHP memory_limit to WDT #7037
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lmcd
commented
Feb 10, 2013
| $this->data = array('memory' => 0); | ||
| $this->data = array( | ||
| 'memory' => 0, | ||
| 'memory_limit' => rtrim(ini_get('memory_limit'), 'M') |
There was a problem hiding this comment.
you need more complex parser of size as decribed in http://www.php.net/manual/en/faq.using.php#faq.using.shorthandbytes
There was a problem hiding this comment.
You can get inspiration from here : https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/File/UploadedFile.php#L230
There was a problem hiding this comment.
Ah, very useful - thanks
There was a problem hiding this comment.
original php implementation https://github.com/php/php-src/blob/master/Zend/zend_operators.c#L110
There was a problem hiding this comment.
hm, this functions minor diffirent when parse 010M for examples - php get this as 8M
fabpot
added a commit
that referenced
this pull request
Mar 18, 2013
This PR was merged into the master branch. Commits ------- a011842 [HttpKernel] fixed memory collector def2ccb Add PHP memory_limit to WDT Discussion ---------- [HttpKernel] fixed memory collector | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7037 --------------------------------------------------------------------------- by vicb at 2013-03-15T20:21:55Z OT, that's great to see many contributions for you @jfsimon, thanks ! --------------------------------------------------------------------------- by jfsimon at 2013-03-18T09:35:54Z Thanks @vicb, this is so lovely :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.