[2.3] [Routing] Some tweaks #7118
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not random but it does not bring anything to the current code. Closing. |
|
@fabpot could you explain me then what #7413 brought in the code ? I don't want to mention the bugs introduced by this PR but truly I would like to understand why a PR gets merged or not beside your opinion. However I am fine if you say that your opinion prime over anything else, I only need to understand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the new version has an improved readability. @fabpot random changes or what ?
At least I have spotted some bugs in the annotation loader that I will fix in the 2.0 branch.