[WIP] Removed deprecated stuff #7227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -216,7 +216,7 @@ public function setDefaultOptions(OptionsResolverInterface $resolver) | |||
| */ | |||
| public function getParent() | |||
| { | |||
| return 'field'; | |||
| return 'form'; | |||
There was a problem hiding this comment.
I think it would be easier to simply remove the whole method getParent because we can inherit the default from AbstractType. Less code is usually better.
|
I created a documentation issue about removing all these things in the documentation as well. I think we should not merge this PR before the documentation is up to date, conform our merging progress. |
Closed
fabpot
added a commit
that referenced
this pull request
Mar 23, 2013
This PR was merged into the master branch. Discussion ---------- [WIP] Removed deprecated stuff Commits ------- f2a8908 removed deprecated functionality from RouteCollection 4f4a5d1 [TwigBundle] removed deprecated syntax 45bd413 [FrameworkBundle] removed deprecated options 0bb5d01 [FrameworkBundle] removed deprecated cookie options b3081e8 [Form] removed deprecated methods and classes e0385a2 [Validator] removed deprecated methods 65e3b16 [Validator] removed deprecated constraints 4a70ddf [HttpFoundation] removed deprecated session methods 4e7943f [Yaml] removed deprecated support of PHP parsin when parsing YAML files 09a5969 [HttpFoundation] removed deprecated Request::splitHttpAcceptHeader() method c28f1b0 removed deprected way to declared trusted proxies 5ff6006 removed deprecated stuff in the fragment sub-framework 0a06a7c [Translation] removed deprecated classes 67f6397 [Security] removed deprecated classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.