[ClassLoader] made DebugClassLoader idempotent #7245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| protected function setUp() | ||
| { | ||
| $this->loader = new UniversalClassLoader(); |
There was a problem hiding this comment.
You should use the ClassLoader rather than the UniversalClassLoader as it is the recommended one
|
ping @fabpot: this will speed up lots of functional tests :) |
| @@ -104,4 +104,9 @@ public function loadClass($class) | |||
| return true; | |||
| } | |||
| } | |||
|
|
|||
| public function getClassFinder() | |||
There was a problem hiding this comment.
What is it for? If this is just for the unit tests, this should be removed and reflection should be used instead.
There was a problem hiding this comment.
Yes, it's just for the test. I'll switch to reflection if you prefer.
Fixed test to use Reflection
fabpot
added a commit
that referenced
this pull request
Mar 8, 2013
This PR was merged into the 2.1 branch. Commits ------- 27cc0df Merge pull request #1 from merk/class-loader/idempotent 95af84c Fixed test to use Reflection bb08247 [ClassLoader] tweaked test 73bead7 [ClassLoader] made DebugClassLoader idempotent Discussion ---------- [ClassLoader] made DebugClassLoader idempotent The DebugClassLoader will wrap itself if `enable()` is called multiple time, such as when running functional tests. Please merge to 2.2 and master ASAP. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ --------------------------------------------------------------------------- by kriswallsmith at 2013-03-07T16:38:55Z ping @fabpot: this will speed up lots of functional tests :) --------------------------------------------------------------------------- by kriswallsmith at 2013-03-08T04:51:51Z @fabpot fixed by @merk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DebugClassLoader will wrap itself if
enable()is called multiple time, such as when running functional tests.Please merge to 2.2 and master ASAP.