[2.2][Routing] Trigger deprecation and refactor tests to not use deprecated methods #7266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -232,7 +243,13 @@ public function addPrefix($prefix, array $defaults = array(), array $requirement | |||
| $this->prefix = '/' . $prefix . $this->prefix; | |||
|
|
|||
| // this is to keep BC | |||
| $options = func_num_args() > 3 ? func_get_arg(3) : array(); | |||
| if (func_num_args() > 3) { | |||
| trigger_error('The forth parameter ($options) of addPrefix() is deprecated since version 2.2 and will be removed in 2.3. ' . | |||
…ll be removed in 2.3
…the tests to only skip the part that really needs the config component
… deprecation internally
fabpot
added a commit
that referenced
this pull request
Mar 6, 2013
This PR was merged into the 2.2 branch. Commits ------- c0687cd remove() should not use deprecated getParent() so it does not trigger deprecation internally 708c0d3 adjust routing tests to not use prefix in addCollection 6180c5b add test for uniqueness of resources c0de07b added tests for addDefaults, addRequirements, addOptions 0a1cfcd adjust RouteCollectionTest for the addCollection change and refactor the tests to only skip the part that really needs the config component ea694e4 added tests for remove() that wasnt covered yet and special route name 9e2bcb5 refactor interator test that was still assuming a tree ceb9ab4 adjust tests to no use addPrefix with options 2b8bf6b adjusted tests to not use RouteCollection::getPrefix acff735 [Routing] trigger deprecation warning for deprecated features that will be removed in 2.3 Discussion ---------- [2.2][Routing] Trigger deprecation and refactor tests to not use deprecated methods | Q | A | ------------- | --- | Bug fix? | [yes] | New feature? | [no] | BC breaks? | [no] | Deprecations? | [no] | Tests pass? | [yes] | License | MIT @fabpot please don't squash because it also added new tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fabpot please don't squash because it also added new tests