Finder unified tests #7296
Closed
Finder unified tests #7296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think you need all this. The issue on Mac is that the temporary folder is actually as symlink. So realpath() is returning a path in |
|
I don't understand the goal of this PR (the tests do currently pass on all platforms). Is it a replacement for #7197? |
|
I missunderstood you, Fabien. In #7197 you said about some problems with tests. Second commit contains alternative method to set tmp dir. |
|
Closing as there are no benefits in this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to correct problems with tests reported by @fabien in #7197.
Can someone run the tests on Mac?
The tests on Windows and on TravisCI pass.