[Console] Progress helper enhancements #7300
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did you test on Windows ? |
|
I don't have a Windows VM, is there an easy way to test on Windows? |
|
I will test it ASAP |
|
|
We do not require mbstring, but we use it optionally when available. See https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Application.php#L784-L794 for instance. |
| public function testMultiByteSupport() | ||
| { | ||
| if (!function_exists('mb_strlen') || (false === $encoding = mb_detect_encoding('■'))) { | ||
| $this->markTestIncomplete('The mbstring extension is needed for multi-byte support'); |
There was a problem hiding this comment.
Shouldn't the test be skipped instead?
There was a problem hiding this comment.
You're right, I'll update it.
|
@fabpot is this good to merge? The failed Travis build seems to come from a different component. |
|
I've submitted a doc change for this PR: symfony/symfony-docs#2342 and added a CHANGELOG entry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two enhancements:
setCurrentmethod to set the current progress. Rather than advancing by 1 or more steps, sometimes you want to just set the current state. For example if you are downloading a file, and a callback provides you with the current download status. A workaround for this could be to keep track of the previous event, calculate the difference, and advancing by the diff. But it's easier to just set the current progress.Sidenotes:
overwritemethod copied documentation of the Output'swritemethod. The difference is, the overwrite method does not handle an array of messages. I've updated the documentation for this.strlento calculate line lengths. This could cause a problem when using multibyte strings. I'd change it tomb_strlen, but I'm not sure if themb_stringextension is required by Symfony.