Skip to content

[HttpKernel] switched Kernel::init() method call to userland #7330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[HttpKernel] switched Kernel::init() method call to userland #7330

wants to merge 1 commit into from

Conversation

bamarni
Copy link
Contributor

@bamarni bamarni commented Mar 11, 2013

Q A
Bug fix? [yes]
New feature? [no]
BC breaks? [yes]
Deprecations? [no]
Tests pass? [yes]
Fixed tickets [#6834]
License MIT

See #6834, as @fabpot said, a fix would be to move the code to userland, I suggest to keep it in this init() method though, and tag it as api, for a few reasons :

  • assuming it's content belongs to the dev front controller is wrong, it only depends on the debug mode.
  • it can become the recommended place where one can set its application specific php ini settings (not sure if there is such place currently for a symfony project? I usually do this in my front controllers) and also set up its own debugging tools, xhprof and so.

@fabpot
Copy link
Member

fabpot commented Mar 23, 2013

Closing in favor of #7441

@fabpot fabpot closed this Mar 23, 2013
fabpot added a commit to fabpot/symfony that referenced this pull request Apr 7, 2013
fabpot added a commit that referenced this pull request Apr 7, 2013
This PR was merged into the master branch.

Discussion
----------

[Debug] added the component (closes #6828, closes #6834, closes #7330)

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #6828, #6834, #7330
| License       | MIT
| Doc PR        | symfony/symfony-docs#2479

You can use the individual tools, or register them all:

```php
use Symfony\Component\Debug\Debug;

Debug::enable();
```

Changes in Symfony SE: symfony/symfony-standard#523

Commits
-------

f693128 fixed typos
1ab1146 [Debug] fixed minor bugs
daa3a3c [Debug] changed composer to accept more versions
e455269 [Debug] ensured that the Debug tools can only be registered once
946bfb2 [Debug] made the exception handler independant of HttpFoundation
2b305c2 added a main Debug class to ease integration
2ff0927 [Debug] added the component (closes #6828, closes #6834, closes #7330)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants