[2.1][TwigBridge] Fixes Issue #7342 in TwigBridge #7344
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbender
commented
Mar 12, 2013
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #7342 |
| License | MIT |
| Doc PR | -- |
|
Can you add a test to avoid regressions ? |
|
Done |
|
Looks good to me? |
| $result = $scope->get('test'); | ||
| $scope->leave(); | ||
|
|
||
| $this->assertEquals($result, null); |
There was a problem hiding this comment.
you could simplify this:
$scope = new Scope();
$scope->enter();
$this->assertNull($scope->get('test'));|
👍 |
fabpot
added a commit
that referenced
this pull request
Mar 13, 2013
This PR was squashed before being merged into the 2.1 branch (closes #7344). Commits ------- c423f16 [2.1][TwigBridge] Fixes Issue #7342 in TwigBridge Discussion ---------- [2.1][TwigBridge] Fixes Issue #7342 in TwigBridge | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7342 | License | MIT | Doc PR | -- --------------------------------------------------------------------------- by stof at 2013-03-12T13:28:15Z Can you add a test to avoid regressions ? --------------------------------------------------------------------------- by benbender at 2013-03-12T13:54:02Z Done --------------------------------------------------------------------------- by stevelacey at 2013-03-12T14:40:59Z Looks good to me? --------------------------------------------------------------------------- by pborreli at 2013-03-12T16:04:27Z :+1:
|
The bug originally fixed by this PR is now double fixed. This PR should be reverted. |
fabpot
added a commit
that referenced
this pull request
Mar 13, 2013
fabpot
added a commit
that referenced
this pull request
Mar 15, 2013
* 2.1: sub-requests are now created with the same class as their parent [FrameworkBundle] removed BC break [FrameworkBundle] changed temp kernel name in cache:clear [DoctrineBridge] Avoids blob values to be logged by doctrine [Security] use current request attributes to generate redirect url? [Validator] fix showing wrong max file size for upload errors [TwigBridge] removed double var initialization (refs #7344) [2.1][TwigBridge] Fixes Issue #7342 in TwigBridge [FrameworkBundle] fixed cahe:clear command's warmup [TwigBridge] now enter/leave scope on Twig_Node_Module [TwigBridge] fixed fixed scope & trans_default_domain node visitor [TwigBridge] fixed non probant tests & added new one [BrowserKit] added ability to ignored malformed set-cookie header [Translation] removed wriong 'use' [Translation] added xliff loader/dumper with resname support [TwigBridge] fixes Conflicts: src/Symfony/Bundle/FrameworkBundle/HttpKernel.php src/Symfony/Component/Security/Http/HttpUtils.php src/Symfony/Component/Translation/Loader/XliffFileLoader.php src/Symfony/Component/Translation/Tests/Loader/XliffFileLoaderTest.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.