I don't like this patch as it feels "unclean". Why not using a SQLite DB in a file?

I use SQLite specifically because it runs in memory, I have a significant amount of tests, and the performance increase of an in-memory database for testing is very helpful.

However, I don't believe this problem is directly related to the Client shutting down the Kernel. My tests using in-memory SQLite worked fine even with the Client shutting down the Kernel. Something else has happened recently that causes the SQLite database to get destroyed.

The last commit I worked from where the Client did shutdown the Kernel, but the SQLite database was not reset was d873f21

If you don't like this method, can we pass a parameter to the doRequest method to specify whether or not the Kernel should be shutdown?

@fabpot
Yea I can understand the point of view that it feels unclean. If it's left as is, there's still the inefficiency of the kernel booting twice in a test:

WebTestCase
public function createClient(array $options = array(), array $server = array())
{
$this->kernel = $this->createKernel($options);
$this->kernel->boot();

FrameworkBundle\Client:
protected function doRequest($request)
{
$this->kernel->shutdown();
$this->kernel->handle($request); // Implicit boot here done inside the kernel

The minimum to solve that is to remove the boot from createClient, however it's needed in order to get the test client. I can't think of any good solution to that at the moment and i think it's mainly a performance consideration, so feel free to close the PR if you don't think it matters.

@Chekote
The alternative I've been using is to add test.client.class: MyProject\Test\Client in my config and do whatever I need in the doRequest

In-memory is obviously quite fast, but I think you are going to run into issues in many scenarios with your approach, where tests will fail like you explained above or will start leaking. Also the more complex your schema and fixtures the longer it will take to reinitialize your db.

So I recommend this Bundle:
https://github.com/liip/FunctionalTestBundle

Basically when using SQLite it can cache the SQLite db files with your schema+fixtures installed and reuse them instead of having to set things up in memory repeatedly.

That's a great bundle, it made a big different for me. With the caching of a file based db, my functional test suite is about 30% quicker than using an in memory db. That difference will just get bigger as well as the project keeps growing, thanks!

Given the existence of FunctionalTestBundle, do you want to close this pull request?

merged