[Form] Deprecated bind() and isBound() in favor of submit() and isSubmitted() #7736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was discussed for a while in #5493. (*) It breaks BC only for people who implemented
FormInterface
manually (not a lot, so I hope). These can fix the problem by simply renamingbind()
andisBound()
in their implementation tosubmit()
andisSubmitted()
.The main rationale is that with the request handlers introduced in #6522, people won't be confronted with the term "binding" anymore. As such,
isBound()
will be a very strange name to new users that have never usedbind()
manually.See this code sample as example:
In reality,
bind()
submits a form. Where-ever I renamed "bind" to "submit" in the comments, "submit" made actually much more sense. So it does in the code sample above:Also when using
submit()
directly, the code makes much more sense now:For current users, the current naming will be supported until 3.0.