Skip to content

[Filesystem] Added a missing test case for Filesystem::dumpFile() #7801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2013

Conversation

jakzal
Copy link
Contributor

@jakzal jakzal commented Apr 22, 2013

This PR adds a test case for the Filesystem::dumpFile() method (introduced in #7753).

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? Build Status
Fixed tickets -
License MIT
Doc PR -

@@ -883,6 +883,17 @@ public function providePathsForIsAbsolutePath()
);
}

public function testDumpsFile()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably be testDumpFile() (no s)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

fabpot added a commit that referenced this pull request Apr 22, 2013
This PR was merged into the master branch.

Discussion
----------

[Filesystem] Added a missing test case for Filesystem::dumpFile()

This PR adds a test case for the ``Filesystem::dumpFile()`` method (introduced in #7753).

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | [![Build Status](https://travis-ci.org/jakzal/symfony.png?branch=dumpfile-tests)](https://travis-ci.org/jakzal/symfony)
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

8fcf4c2 [Filesystem] Added a missing test case for Filesystem::dumpFile().
@fabpot fabpot merged commit 8fcf4c2 into symfony:master Apr 22, 2013
@jakzal jakzal deleted the dumpfile-tests branch April 23, 2013 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants