[Security] Outsource all the BCrypt heavy lifting to a library #7853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
Apr 25, 2013
This PR was merged into the master branch. Discussion ---------- [Security] Outsource all the BCrypt heavy lifting to a library | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | License | MIT The [BCrypt bundle](https://github.com/elnur/ElnurBlowfishPasswordEncoderBundle) is already using the library. This is a working implementation of #7247 Commits ------- c83546d [Security] tweaked previous commit b2e553a Outsource all the BCrypt heavy lifting to a library
|
Shouldn't you mention in the changelog that the password-compat library must be installed when using bcrypt and |
|
@sstok: done |
fabpot
added a commit
that referenced
this pull request
Apr 26, 2013
fabpot
added a commit
that referenced
this pull request
Apr 26, 2013
|
I've also added an exception when the BCrypt encoder cannot be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BCrypt bundle is already using the library.
This is a working implementation of #7247