[2.2][Security] concurrent sessions #786

paschke · 2011-05-05T13:31:01Z

an implementation of the Spring concurrent sessions in the Security Component, now using Doctrine DBAL. Can be configured like:

security:
    ...
    session_registry:
        connection: default
        tables:
            session_information: cs_session_information

    firewalls:
        ...
        secured_area:
            ...
            session_concurrency:
                max_sessions: 5
                expiration_url: /expired

to init, run the init:concurrent-session command, which will create a DBAL implementation of the Symfony\Component\Security\Http\Session\SessionRegistryStorageInterface. You can also provide a custom implementation.

…ions

… Component

stof · 2011-05-07T17:23:36Z

Shouldn't it be what the Symfony\Bridge\Doctrine namespace is for ?

lsmith77 · 2011-06-06T07:13:33Z

src/Symfony/Bundle/SecurityBundle/Command/InitConcurrentSessionsCommand.php

+
+        $this
+            ->setName('init:concurrent-session')
+            ->setDescription('Executes the SQL needed to generate the database schema reqired by the concurrent sessions feature.')


s/reqired/required

typo still needs to be fixed

lsmith77 · 2011-06-06T11:29:46Z

I guess the big question if to use the ORM or the DBAL. obviously there will be a need for some model object either way.

…Session\SessionRegistryStorageInterface

…ions

… Component

…Session\SessionRegistryStorageInterface

stof · 2012-02-23T12:33:08Z

src/Symfony/Component/Security/Http/Session/ConcurrentSessionControlStrategy.php

+     *
+     * @param Request $request
+     * @param TokenInterface $token
+     * @return void


please remove these @return void. Sf2 does not use them. And this method should use {@inheritdoc}

stof · 2012-04-04T02:21:01Z

@fabpot @schmittjoh what do you think about it ?

paschke · 2012-04-04T07:54:26Z

sorry I haven't reacted to your comments, customer is not requesting the feature any more and I need to continue on my own time, of which I have little atm. I basically agree with your suggestions and will implement them asap.

…ependencyInjection/SecurityExtension::sessionRegistryLoad

…ally

Baachi · 2012-04-11T08:29:47Z

src/Symfony/Component/Security/Http/Session/ConcurrentSessionControlStrategy.php

+
+        parent::onAuthentication($request, $token);
+
+        if ($originalSessionId != $request->getSession()->getId()) {


Should be !==

stof · 2012-04-11T08:52:12Z

Tests are missing

dlsniper · 2013-01-09T09:49:46Z

This is tagged with [2.2] what's the status of it? If it needs to be rebased I'm in for helping out, as well as the reminder of comments from @stof
For tests I'll need to get a better look on it but @schmittjoh said a year ago he doesn't have time for it and @fabpot hasn't replied yet.

fabpot · 2013-04-25T12:24:01Z

I'm closing this old PR as there is no more activity on it and because it probably does not apply anymore cleanly. I've opened a ticket about this feature request at #7845

Stefan Paschke added 7 commits May 4, 2011 17:25

added listener, strategy, registry, configuration for concurrent sess…

c0b33f8

…ions

added SessionLogoutHandler to setup of ConcurrentSessionListener

0f3d7c4

removed uneeded interface

e9bcd84

Merge branch 'master' of https://github.com/symfony/symfony

9f4a52d

removed security.authentication.session_registry_storage service from…

507befa

… Component

removed unneeded methods

5559ef8

Merge branch 'master' of https://github.com/symfony/symfony

238606b

Stefan Paschke added 6 commits May 17, 2011 10:05

prepare Doctrine implementation of SessionRegistryStorage

455197f

Merge branch 'master' of github.com:paschke/symfony

a4eeae5

default Doctrine implementation of SessionInformation

aadb2a7

Merge branch 'master' of https://github.com/symfony/symfony

5b5edd8

removed SessionInformationIterator class

33d83b4

forgot query condition

624b01f

lsmith77 reviewed Jun 6, 2011
View reviewed changes

Stefan Paschke added 14 commits December 15, 2011 14:20

Merge branch 'master' of github.com:symfony/symfony

7032534

added DBAL default implementation of Symfony\Component\Security\Http\…

bc182f9

…Session\SessionRegistryStorageInterface

recreate SessionInformation if they were lost from the registry

d0c826a

minor fixes

c9f08a4

added listener, strategy, registry, configuration for concurrent sess…

13813da

…ions

added SessionLogoutHandler to setup of ConcurrentSessionListener

8ef6923

removed uneeded interface

f4f0a8c

removed security.authentication.session_registry_storage service from…

e11a540

… Component

removed unneeded methods

a3d0a59

prepare Doctrine implementation of SessionRegistryStorage

c800408

default Doctrine implementation of SessionInformation

9c8bd21

removed SessionInformationIterator class

2efbf11

forgot query condition

3cb882c

added DBAL default implementation of Symfony\Component\Security\Http\…

0aa9353

…Session\SessionRegistryStorageInterface

stof reviewed Feb 23, 2012
View reviewed changes

Stefan Paschke added 5 commits April 8, 2012 15:56

removed @return void comments

ac7a1d6

Merge branch 'master' of git://github.com/symfony/symfony

b24a364

reacting to comments on PR 786

f7dfb3f

reuse the instance level loader n src/Symfony/Bundle/SecurityBundle/D…

3cef9bb

…ependencyInjection/SecurityExtension::sessionRegistryLoad

passing sessionStrategy into authenticationListenerFactories individu…

d567980

…ally

Baachi reviewed Apr 11, 2012
View reviewed changes

fabpot mentioned this pull request Apr 25, 2013

Support concurrent sessions #7845

Closed

fabpot closed this Apr 25, 2013

ajgarlag mentioned this pull request Sep 24, 2014

[WIP] [Security] Session concurrency control #12009

Closed

ajgarlag referenced this pull request in ajgarlag/symfony Sep 24, 2014

Previous PR

38179de

ajgarlag mentioned this pull request Oct 11, 2017

[Security] Idle sessions expiration. #12807

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[2.2][Security] concurrent sessions #786

[2.2][Security] concurrent sessions #786

Uh oh!

paschke commented May 5, 2011

Uh oh!

stof commented May 7, 2011

Uh oh!

lsmith77 Jun 6, 2011

Uh oh!

lsmith77 Dec 20, 2011

Uh oh!

lsmith77 commented Jun 6, 2011

Uh oh!

stof Feb 23, 2012

Uh oh!

paschke Apr 9, 2012

Uh oh!

stof commented Apr 4, 2012

Uh oh!

paschke commented Apr 4, 2012

Uh oh!

Baachi Apr 11, 2012

Uh oh!

stof commented Apr 11, 2012

Uh oh!

dlsniper commented Jan 9, 2013

Uh oh!

fabpot commented Apr 25, 2013

Uh oh!

Uh oh!


		parent::onAuthentication($request, $token);

		if ($originalSessionId != $request->getSession()->getId()) {

Uh oh!

[2.2][Security] concurrent sessions #786

[2.2][Security] concurrent sessions #786

Uh oh!

Conversation

paschke commented May 5, 2011

Uh oh!

stof commented May 7, 2011

Uh oh!

lsmith77 Jun 6, 2011

Choose a reason for hiding this comment

Uh oh!

lsmith77 Dec 20, 2011

Choose a reason for hiding this comment

Uh oh!

lsmith77 commented Jun 6, 2011

Uh oh!

stof Feb 23, 2012

Choose a reason for hiding this comment

Uh oh!

paschke Apr 9, 2012

Choose a reason for hiding this comment

Uh oh!

stof commented Apr 4, 2012

Uh oh!

paschke commented Apr 4, 2012

Uh oh!

Baachi Apr 11, 2012

Choose a reason for hiding this comment

Uh oh!

stof commented Apr 11, 2012

Uh oh!

dlsniper commented Jan 9, 2013

Uh oh!

fabpot commented Apr 25, 2013

Uh oh!

Uh oh!