[Form] *_SET_DATA events are now guaranteed to be fired *after* the initial children were added #7878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
webmozart
commented
Apr 29, 2013
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #7873 |
| License | MIT |
| Doc PR | - |
…nitial children were added
fabpot
added a commit
that referenced
this pull request
Apr 30, 2013
This PR was merged into the master branch. Discussion ---------- [Form] *_SET_DATA events are now guaranteed to be fired *after* the initial children were added | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7873 | License | MIT | Doc PR | - Commits ------- 441222e [Form] *_SET_DATA events are now guaranteed to be fired *after* the initial children were added
| */ | ||
| public function initialize() | ||
| { | ||
| throw new BadMethodCallException('Buttons cannot be initialized. Call initialized() on the root form instead.'); |
There was a problem hiding this comment.
shouldn'tit be initialize() here ?
webmozart
added a commit
to webmozart/symfony
that referenced
this pull request
May 2, 2013
fabpot
added a commit
that referenced
this pull request
May 2, 2013
This PR was merged into the master branch. Discussion ---------- [Form] Fixed stofs from #7878 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 1939dfc [Form] Fixed stofs from #7878
|
Is this for 2.3 only? |
|
@trsteel88 yes it is. As it required breaking BC to add new methods in the interface, it could not be merged in older branches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.