Update Crawler.php #7963
Merged
Update Crawler.php #7963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If HTML is not well-formed XML parsing goes wrong.
|
As this is a new method in 2.3, I would rather add an argument to the Perhaps that we should then find another name for the method itself (instead of |
fabpot
added a commit
that referenced
this pull request
May 10, 2013
This PR was merged into the master branch. Discussion ---------- Update Crawler.php If HTML is not well-formed XML parsing goes wrong. Could be useful create another method returning XML and XHTML in a `well-formed` standard? Commits ------- 0a26641 Update Crawler.php
|
@fabpot @spil-giacomo the node argument in the In PHP 5.3.3 one of the tests fails: |
|
Yes, could be a solution now having one method to switch. I agree. |
fabpot
added a commit
that referenced
this pull request
May 13, 2013
This PR was merged into the master branch. Discussion ---------- [DomCrawler] Fixed the Crawler::html() method for early PHP versions | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes, but not on travis (segfault) | Fixed tickets | #7963 | License | MIT | Doc PR | - Node argument was added to the [`DOMDocument::saveHTML()`](http://php.net/manual/en/domdocument.savehtml.php) in PHP 5.3.6. See http://php.net/manual/en/domdocument.savehtml.php. It's not a nice looking solution, but seems to be the only option. Condition should be removed once PHP dependency goes over 5.3.6. Commits ------- a4e3ebf [DomCrawler] Fixed the Crawler::html() method for PHP versions earlier than 5.3.6.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If HTML is not well-formed XML parsing goes wrong.
Could be useful create another method returning XML and XHTML in a
well-formedstandard?