Skip to content

[WIP][FrameworkBundle] Use new table helper in container:debug command #8002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Burgov
Copy link
Contributor

@Burgov Burgov commented May 10, 2013

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This PR updates the container:debug command in order to make use of the new Table output helper. This should make the code cleaner and easer to maintain in the future. There are some issues which probably should be discussed before continuing/merging:

  • The layout breaks badly if the table doesn't fit into the console. For the normal services dump this won't occur so quickly, but when I tried to apply this on the --parameters command, it became unreadable
  • The layout breaks if you use (or other) tags. The helper will take the chars in account, while they are not rendered. I stripped them for now
  • I wanted to apply the helper on the service information view, but i think it won't be applicable... E.g. app/console container:debug data_collector.router.

Let me know what you think about the issues

@fabpot
Copy link
Member

fabpot commented Oct 1, 2013

Closing as it was done in #8451

@fabpot fabpot closed this Oct 1, 2013
@Burgov
Copy link
Contributor Author

Burgov commented Oct 1, 2013

@fabpot Maybe I'm overlooking something, but I don't really see how these two PR's are related?

@fabpot
Copy link
Member

fabpot commented Oct 2, 2013

Oops, the good PR is #7887. Unfortunately, I've just discovered that the PR is totally broken, so I'm working on fixing it now: see #9195.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants