Improvement composer.json Console #8029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,6 +21,9 @@ | |||
| "require-dev": { | |||
| "symfony/event-dispatcher": "~2.1" | |||
| }, | |||
| "suggest": { | |||
| "symfony/event-dispatcher": "~2.1" | |||
There was a problem hiding this comment.
you should use something descriptive instead of the version (or just have the empty string)
There was a problem hiding this comment.
I know this but the Symfony follow this default see https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Validator/composer.json.
There was a problem hiding this comment.
all versions will be replaced by a single string in #8017 And I want to make them all descriptive, as that's the best.
There was a problem hiding this comment.
Can be a message generic "You should install this package to use ...." ZF2 adopt this default in some packages.
fabpot
added a commit
that referenced
this pull request
May 15, 2013
This PR was merged into the master branch. Discussion ---------- Improvement composer.json Console Added suggest to composer.json. Commits ------- 5e6245f [ADD] Component_Console -add suggest in the composer.json to event-dispatcher
fabpot
added a commit
that referenced
this pull request
May 15, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added suggest to composer.json.