[Console] fix Output classes #8037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d a failing test for verbosity
It should not extend from abstract Output class because than it inherits the useless constructor arguments and applies formatting in write() needlessly.
…sing of decorated variable. Also we don't need to typecast to boolean as its already done by the formatter and its his responsibility
…ities) also add missing information
fabpot
added a commit
that referenced
this pull request
May 15, 2013
This PR was merged into the master branch. Discussion ---------- [Console] fix Output classes Please see commits. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Commits ------- 940b788 [Console] use inheritdoc for Output classes bd61b92 [Console] fix phpdoc of Output classes (esp. regarding the new verbosities) 9dcc9fa [Console] fix abstract Output class that fasly claims to support guessing of decorated variable. 2628d88 [Console] the default type value should use the constant in OutputInterface::write ee0cc40 [Console] fix NullOutput a290f87 [Console] fix test for NullOutput that does not print anything and add a failing test for verbosity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see commits.