Skip to content

[TwigBridge] Added missing column to the form's table layout #8059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

webmozart
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@stloyd
Copy link
Contributor

stloyd commented May 16, 2013

@bschussek Symfony/Bundle/FrameworkBundle/Resources/views/FormTable/button_row.html.php should be changed too, and test: Symfony/Component/Form/Tests/AbstractTableLayoutTest.php

@webmozart
Copy link
Contributor Author

@stloyd Why?

@stloyd
Copy link
Contributor

stloyd commented May 16, 2013

@bschussek Check: #8043 & #8053.

@webmozart webmozart mentioned this pull request May 16, 2013
@webmozart
Copy link
Contributor Author

Both #8043 and #8053 were wrong. The PHP template and the test are fine. :)

@stloyd
Copy link
Contributor

stloyd commented May 16, 2013

@bschussek This should go to 2.3 probably as #8043 is there =)

@webmozart
Copy link
Contributor Author

Ah, I didn't see that branch exists yet. @fabpot do you need a new PR?

fabpot added a commit that referenced this pull request May 16, 2013
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #8059).

Discussion
----------

[TwigBridge] Added missing column to the form's table layout

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

97f3669 [TwigBridge] Added missing column to the form's table layout
@fabpot
Copy link
Member

fabpot commented May 16, 2013

@bschussek no need to create another, I can switch the branch on my side easily.

@fabpot fabpot closed this May 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants