[FrameworkBundle][Command] print registered event-listeners + event-subscribers #8234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * @param InputInterface $input | ||
| * @param OutputInterface $output | ||
| * @return void |
|
unittests are needed? |
| $class = $containerBuilder->getDefinition($id)->getClass(); | ||
|
|
||
| $refClass = new \ReflectionClass($class); | ||
| $interface = 'Symfony\Component\EventDispatcher\EventSubscriberInterface'; |
There was a problem hiding this comment.
This should be moved out off loop, or even hardcoded, as it's not used anymore.
| $table = $this->getHelperSet()->get('table'); | ||
| $table | ||
| ->setHeaders(array('Class', 'Event')) | ||
| ->setLayout(TableHelper::LAYOUT_BORDERLESS) |
There was a problem hiding this comment.
Why not using default layout?
There was a problem hiding this comment.
The table should look like the "container:debug" command
There was a problem hiding this comment.
But it does not, does it?
I opened #8292 to fix that.
|
IMHO, you should add a big warning: You can display only "configured" listener. i.e.: You can not display listener created during the run-time. I know this is obvious, but not for every body. |
| { | ||
| $this | ||
| ->setName('event_dispatcher:debug') | ||
| ->addArgument('event', InputArgument::OPTIONAL, 'Show listeners for a event', '') |
There was a problem hiding this comment.
you can leave the '' last argument as it is defaulting to null also
7 tasks
|
closing in favor of #10388 |
fabpot
added a commit
that referenced
this pull request
Sep 15, 2014
…isplay registered listeners (matthieuauger) This PR was merged into the 2.6-dev branch. Discussion ---------- [FrameworkBundle] [Command] Event Dispatcher Debug - Display registered listeners | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT ------------------------------------------ [Update] The PR has been updated in order to comply with @stof comments. Current status : - [x] New event dispatcher Descriptor - [x] Manage all callables - [x] Unit tests - [x] Text description - [x] XML description - [x] Json description - [x] Markdown description ----------------------------------------- Hi. In some big applications with lots of events, it's often hard to debug which classes listen to which events, and what is the order of theses listeners. This PR allows to run - *event-dispatcher:debug* which displays all configured listeners + the events they listen to  - *event-dispatcher:debug* **event** which displays configured listeners for this specific event (order by priority desc)  The output is similar to *container:debug* command and is available in all supported formats (txt, xml, json and markdown). I found another PR with same goal (#8234), but the approach looks too complicated to me plus I think we should fetch the listeners directly with the event_dispatcher. Commits ------- ce53c8a [FrameworkBundle] Add Event Dispatcher debug command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New console-command for the event-dispatcher. The command prints a table like the
container:debugcommand with all registered events and their event-listeners.The list is sorted by events.
There is an additional argument
event. If this parameter is set, the command prints the listener for the event.