[Intl] made RegionBundle merge fallback data if using a country-specific locale #8564
Conversation
|
Can you add a test that was failing before your fix? |
|
I've added a case to the test for |
| $this->context->expects($this->never()) | ||
| ->method('addViolation'); | ||
|
|
||
| $this->validator->validate($existingCountry, new Country()); |
There was a problem hiding this comment.
You need to add some assertion, otherwise this test will be marked as fail when run (phpunit) in strict mode.
There was a problem hiding this comment.
Doesn't the same apply to all the other test cases in that class currently there (and most of the other tests against validators, for that matter)?
There was a problem hiding this comment.
@stloyd $this->context->expects($this->never()) is an assertion
There was a problem hiding this comment.
Again forgot something about phpunit 😢
|
BTW: Is it really only the country data that's not merged back or is it everything? |
|
This issue only refers to countries as this is the concern of the RegionBundle, but it would be worth checking other data sets. |
|
As it happens, yes, it looks like currencies and languages would suffer from the same issue. |
|
I've made a similar change to the |
…using a country-specific locale
|
Any chance of a merge? (Or, consideration of the |
|
This would also help me out; it's holding back a production update from 2.2 to 2.3 |
|
ping @bschussek |
|
Hi just tripped over this issue too while upgrading to 2.3. Cannot go live with this till there is a fix and really want to start playing with 2.3 please. |
This PR was merged into the 2.3 branch. Discussion ---------- [Intl] made RegionBundle merge fallback data if using a country-specific locale See #8442 and symfony/Icu#2. Essentially, country data fetches from the Intl component do not currently work when using a locale with a country specifier, e.g. `fr_FR`. This change forces a merge on the data against the root language locale, thus making country data available for such locales. Commits ------- 52d8676 [Intl] made RegionBundle and LanguageBundle merge fallback data when using a country-specific locale
|
Hi. However this fix his does not yet appear to have made it into 2.3.5-DEV any reason for this? also when is 2.3.5 likely to be released with this fix in place? Thanks for all your hard work. |
|
@penfold45 This fix is currently in the 2.3 branch - I'm not sure what you are checking out as 2.3.5-DEV but it should contain the change. |
|
mmm odd. Yes I can now see it in github on 2.3 Branch but not in the code I pulled. I will take a look again at the code I pulled and see what I did wrong. Sorry about that. Any idea when 2.3.5 is going to be released? I am happy to test the code works but don't really want to go on to production on the branch? |
|
I don't know when 2.3.5 will be released, but my expectation is that it'll be pretty soon. |
|
@penfold45 fyi 2.3.5 was tagged/released this morning. |
See #8442 and symfony/Icu#2.
Essentially, country data fetches from the Intl component do not currently work when using a locale with a country specifier, e.g.
fr_FR. This change forces a merge on the data against the root language locale, thus making country data available for such locales.